Use the standard comment marker in SQL migration files #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -107,7 +107,6 @@ private function buildMigrationFilePath() | |||
| { | |||
| $path = $this->destPath; | |||
| if (is_dir($path)) { | |||
| $path = realpath($path); | |||
There was a problem hiding this comment.
I need to remove the realpath call because https://github.com/mikey179/vfsStream/wiki/Known-Issues
I hope that adding this dependency is not a problem.
|
@aaa2000 Can you add tests to verify that the removing of the realpath call did not break anything ? |
aaa2000
force-pushed
the
fix-sql-files-on-postgresql
branch
from
212a3eb to
569813b
Compare
|
@mikeSimonson I have keept the realpath call and modified tests by mocking realpath in order to be sure that it did not break anything. |
|
@aaa2000 That works too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #466