Add Tests for ExecuteCommand #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done with the Symfony console command tester. Closes doctrine#297
|
|
||
| protected function setUp() | ||
| { | ||
| $this->questions = $this->getMock(QuestionHelper::class); |
There was a problem hiding this comment.
You just need to add something similar to the test here https://github.com/doctrine/migrations/blob/master/bin/doctrine-migrations.php#L74-L78 and then the last test will pass.
Thanks a lot for the PR.
|
@chrisguitarguy Thanks a lot for the tests. |
Includes using the dialog helper as well as some small changes for the command tester.
|
Should be good to go @mikeSimonson, didn't think about the |
|
@chrisguitarguy Thanks you are awesome |
|
No problem, @mikeSimonson. On vacation this week, so I thought I'd get back to helping out with migrations a bit. |
|
still awesome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done with the Symfony console command tester.
Closes #297