Explicitly Call Connection::connect in Configuration
#479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And account for uses of `MasterSlaveConnection`. If there is a `MasterSlaveConnection` in use, the migrations system should always talk to master just incase replication is behind the next migration execution. Should (hopefully) close doctrine#336
| protected function connect() | ||
| { | ||
| if ($this->connection instanceof MasterSlaveConnection) { | ||
| return $this->connection->connect('master'); |
There was a problem hiding this comment.
@chrisguitarguy This does assume that there is always a connection named master in a master slave connection setup right ?
If so, is it the case or should we make the name of the master connection configurable ?
There was a problem hiding this comment.
Good question. MasterSlaveConection only accepts master and slave as arguments to connect, so we should be okay.
|
@chrisguitarguy And one more fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And account for uses of
MasterSlaveConnection. If there is aMasterSlaveConnectionin use, the migrations system should always talk to master just in case replication is behind the next migration execution.Should (hopefully) close #336
When using
MasterSlaveConnection, any calls to the connectionsexecuteQuerymethod (which includes all thefetch*methods) will connect to followers (slaves). Even things like checking if the migration table exists fall into this category. If the replication is behind, the followers may not have the real, already executed migrations.