Show the sql statement parameters if they exist #513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -407,7 +407,8 @@ private function executeRegisteredSql($dryRun = false, $timeAllQueries = false) | |||
| $this->outputWriter->write(' <comment>-></comment> ' . $query); | |||
| $this->connection->executeQuery($query); | |||
| } else { | |||
| $this->outputWriter->write(sprintf(' <comment>-</comment> %s (with parameters)', $query)); | |||
| $parameters = implode(', ', $this->params[$key]); | |||
| $this->outputWriter->write(sprintf(' <comment>-</comment> %s (%s)', $query, $parameters)); | |||
There was a problem hiding this comment.
This whole bit (including the if/else check for the params) could be replaced with $this->outputSqlQuery($key, $query).
I added that in #477 -- uses the doctrine types system to convert the params into something printable.
There was a problem hiding this comment.
It would be better indeed.
mikeSimonson
force-pushed
the
show-sql-stmt-params
branch
from
1f9e1ed to
eff7d50
Compare
|
@chrisguitarguy Thanks for the review |
| $this->connection->executeQuery($query); | ||
| } else { | ||
| $this->outputWriter->write(sprintf(' <comment>-</comment> %s (with parameters)', $query)); | ||
| $this->outputSqlQuery($key, $query); |
There was a problem hiding this comment.
The calls to $this->outputSqlQuery could be moved above the if/else block here.
mikeSimonson
force-pushed
the
show-sql-stmt-params
branch
from
eff7d50 to
3ebe6cd
Compare
sstalle
reviewed
Jun 3, 2017
| @@ -403,11 +403,10 @@ private function executeRegisteredSql($dryRun = false, $timeAllQueries = false) | |||
| foreach ($this->sql as $key => $query) { | |||
| $queryStart = microtime(true); | |||
|
|
|||
| $this->outputSqlQuery($key, $query); | |||
|
This is implemented and covered by tests now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.