Fix DiffGenerator #823
Merged
Fix DiffGenerator #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw. any reason for having a lock file committed in the repo? Afaik it's not considered good practice for libraries. |
enumag
force-pushed
the
patch-2
branch
3 times, most recently
from
d086b5f to
323e4d6
Compare
|
@enumag The Doctrine team decided to commit the lock file. There are reasons for it - so it's not by accident :) |
|
@weaverryan Obviously. What are the reasons? |
|
@enumag We have some information about that here https://www.doctrine-project.org/policies.html |
|
@jwage I don't necessarily agree with the policy since you won't get notified about test failures caused by newer versions of other libraries. Tools like phpstan could be version-locked in the composer.json instead. But anyway thanks for the link. |
|
The same issue exists in doctrine-fixtures, FYI. |
|
So... can anyone do a review for me here? |
jwage
approved these changes
May 24, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
getFilterSchemaAssetsExpressionmethod is deprecated and with DoctrineBundle 1.11 it no longer returns the filter used in Symfony configuration. Because of that the schema filter was not applied and migrations generated extra tables in our system.