Lazy console commands #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will do this in other doctrine repos soon. |
alcaeus
approved these changes
Jul 16, 2019
localheinz
reviewed
Jul 23, 2019
This explanation is perfect, and should be included in your commit message. |
SenseException
approved these changes
Jul 29, 2019
|
Thanks @vudaltsov! |
mbrodala
added a commit
to mbrodala/typo3-ext-migrations
that referenced
this pull request
Mar 23, 2020
Due to some logic in Symfony "Command" the default name of extended commands is not used in the extending command. So we need to copy all of them. See doctrine/migrations#839 And symfony/symfony#23887
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Symfony
3.4console commands can be lazy thanks to a static name property.This change does not break BC because the BC layer is already in the base command's constructor.