Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executed at must be an integer #889

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Conversation

goetas
Copy link
Member

@goetas goetas commented Dec 6, 2019

Q A
Type bug
BC Break -
Fixed issues

Summary

  • executed_at must be an integer

@goetas goetas requested a review from alcaeus December 6, 2019 07:21
@goetas goetas force-pushed the executed-at-integer branch from ec8a533 to a1ad46b Compare December 7, 2019 15:16
@goetas
Copy link
Member Author

goetas commented Dec 7, 2019

I have reworked this PR. Now internally the executed time is a float (number of seconds+microtime), but when that value gets saved to the database, it gets converted in an integer (multiplied for 1000).
In this way at DB level is an integer (better compatibility with different databases). When saving the execution time, we loose the microseconds part, but I think that having milliseconds is enough.

@goetas goetas requested a review from alcaeus December 7, 2019 15:32
@goetas goetas marked this pull request as ready for review December 7, 2019 15:33
@goetas goetas added the Bug label Dec 7, 2019
@goetas goetas merged commit 7ffde26 into doctrine:master Dec 10, 2019
@goetas goetas deleted the executed-at-integer branch December 10, 2019 08:47
@goetas goetas added this to the 3.0.0 milestone Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants