Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize schema table even on reset #890

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Initialize schema table even on reset #890

merged 1 commit into from
Dec 9, 2019

Conversation

goetas
Copy link
Member

@goetas goetas commented Dec 7, 2019

Q A
Type bug
BC Break yes
Fixed issues -

Summary

Do not crash when calling reset on a database that has no schema table yet

@goetas goetas added the Bug label Dec 7, 2019
greg0ire
greg0ire approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rightfully targets master since the patched class exists only on that branch (it appeared in the big PR)

@goetas goetas merged commit ad8d5c3 into master Dec 9, 2019
@goetas goetas deleted the reset-schema branch December 9, 2019 18:42
@goetas goetas added this to the 3.0.0 milestone Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@goetas @greg0ire