Support multiple versions in ExecuteCommand #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetas
force-pushed
the
multiple-versons-exec
branch
from
8b1d5cc to
e6646de
Compare
SenseException
requested changes
Dec 13, 2019
|
@SenseException good catch. I have also added more tests to make sure migrations are properly sorted (keeping sort order and not the order provided by the user via command line) |
|
Any other feedback on this? |
greg0ire
reviewed
Dec 19, 2019
alcaeus
requested changes
Dec 20, 2019
lib/Doctrine/Migrations/Tools/Console/Command/ExecuteCommand.php
Outdated
Show resolved
Hide resolved
goetas
force-pushed
the
multiple-versons-exec
branch
2 times, most recently
from
7f1e435 to
c820fa4
Compare
greg0ire
reviewed
Dec 21, 2019
lib/Doctrine/Migrations/Tools/Console/Command/ExecuteCommand.php
Outdated
Show resolved
Hide resolved
greg0ire
approved these changes
Dec 21, 2019
goetas
force-pushed
the
multiple-versons-exec
branch
from
bf89d43 to
4c7a71b
Compare
|
@alcaeus @SenseException the changes you asked are done. can you please check again/approve this PR? |
SenseException
approved these changes
Jan 2, 2020
goetas
force-pushed
the
multiple-versons-exec
branch
from
4c7a71b to
7b9dccd
Compare
|
Rebased on top of the latest master branch. |
alcaeus
approved these changes
Jan 14, 2020
|
Thanks @goetas ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation of #796 for the 3.x branch