Drop helperset usage in favor of the DependencyFactory #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 29, 2019
jwage
approved these changes
Dec 30, 2019
greg0ire
reviewed
Dec 31, 2019
lib/Doctrine/Migrations/Configuration/ConfigurationFormatLoader.php
Outdated
Show resolved
Hide resolved
lib/Doctrine/Migrations/Configuration/Connection/ConfiguredConnectionLoader.php
Outdated
Show resolved
Hide resolved
lib/Doctrine/Migrations/Tools/Console/Command/DoctrineCommand.php
Outdated
Show resolved
Hide resolved
goetas
force-pushed
the
remove-helperset-usage
branch
4 times, most recently
from
f4e8975 to
dd84fbd
Compare
|
this is ready for review |
goetas
force-pushed
the
remove-helperset-usage
branch
2 times, most recently
from
f038112 to
ece01e0
Compare
alcaeus
reviewed
Jan 10, 2020
| @@ -2,8 +2,9 @@ | |||
|
|
|||
| declare(strict_types=1); | |||
|
|
|||
| namespace Doctrine\Migrations\Configuration\Exception; | |||
| namespace Doctrine\Migrations\Configuration\Configuration\Exception; | |||
There was a problem hiding this comment.
Is this on purpose? I find the double Configuration in the namespace rather strange.
There was a problem hiding this comment.
It is intentional. I'm also not very happy, but was done to give come structure. Currently there are 3 types of configurations: Migration configs, Connection configs and Entity manager configs. So the idea was to keep all of them in the same folder, but in 3 subfolders.
If you have another idea, will be happy to change it.
There was a problem hiding this comment.
How about Doctrine\Migrations\Configuration\(EntityManager|Connection|Migration)? Configuration\Configuration seems odd, and doesn't convey why we need the additional subnamespace.
lib/Doctrine/Migrations/Configuration/Configuration/Exception/InvalidConfigurationFormat.php
Outdated
Show resolved
Hide resolved
lib/Doctrine/Migrations/Configuration/Configuration/Exception/MissingConfigurationFile.php
Show resolved
Hide resolved
lib/Doctrine/Migrations/Configuration/Connection/ConfigurationFile.php
Outdated
Show resolved
Hide resolved
lib/Doctrine/Migrations/Configuration/Connection/ExistingConnection.php
Outdated
Show resolved
Hide resolved
lib/Doctrine/Migrations/Configuration/EntityManager/ConfigurationFile.php
Outdated
Show resolved
Hide resolved
lib/Doctrine/Migrations/Configuration/EntityManager/ExistingEntityManager.php
Outdated
Show resolved
Hide resolved
goetas
force-pushed
the
remove-helperset-usage
branch
from
3d4ffea to
1f96b53
Compare
greg0ire
reviewed
Jan 12, 2020
lib/Doctrine/Migrations/Configuration/Configuration/Exception/InvalidConfigurationFormat.php
Outdated
Show resolved
Hide resolved
tests/Doctrine/Migrations/Tests/Tools/Console/Command/LatestCommandTest.php
Outdated
Show resolved
Hide resolved
tests/Doctrine/Migrations/Tests/Tools/Console/Command/MigrationVersionTest.php
Outdated
Show resolved
Hide resolved
tests/Doctrine/Migrations/Tests/Tools/Console/Command/StatusCommandTest.php
Outdated
Show resolved
Hide resolved
tests/Doctrine/Migrations/Tests/Tools/Console/Command/UpToDateCommandTest.php
Outdated
Show resolved
Hide resolved
tests/Doctrine/Migrations/Tests/Tools/Console/ConsoleRunnerTest.php
Outdated
Show resolved
Hide resolved
Co-Authored-By: Grégoire Paris <[email protected]>
Co-Authored-By: Grégoire Paris <[email protected]>
goetas
force-pushed
the
remove-helperset-usage
branch
from
8c05a66 to
442c9a8
Compare
|
@greg0ire all your comments have been addressed except the one where the conversation is not marked as resolved. |
greg0ire
approved these changes
Jan 13, 2020
alcaeus
approved these changes
Jan 14, 2020
|
Thanks @goetas ! |
This was referenced Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Even if symfony/symfony#27647 did not pass, it is a good idea to not depend on the symfony helperset feature. The doctrine's DependencyFactory is a better way to get command dependencies.