Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to decorate dependency factory services #926

Closed
wants to merge 1 commit into from

Conversation

goetas
Copy link
Member

@goetas goetas commented Jan 31, 2020

Q A
Type feature
BC Break -
Fixed issues -

Summary

The DI factory become a central extension point for doctrine migrations.
Being able to decorate services is fundamental for most of DI containers and allows to apply composition over inheritance

@goetas goetas force-pushed the dependency-factory-decorator branch from f69f4d1 to 5f19e28 Compare January 31, 2020 08:39
@goetas goetas added this to the 3.0.0 milestone Jan 31, 2020
@goetas
Copy link
Member Author

goetas commented Feb 1, 2020

thinking it twice, this is already possible by doing

$oldComparator = $di->getComparator();
$oldComparator->setComparator(new NewComparator($oldComparator));

@goetas goetas closed this Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant