Allow to change configurations in the dependency factory #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetas
commented
Apr 8, 2020
goetas
changed the title
goetas
force-pushed
the
allow-custom-configs-at-runtime
branch
from
4dd77ad to
7684400
Compare
…has already been provided
…e running the tests
goetas
force-pushed
the
allow-custom-configs-at-runtime
branch
from
7684400 to
a83b5d3
Compare
goetas
changed the title
|
Functionality wise this has been tested in doctrine/DoctrineMigrationsBundle#311 (comment) |
SenseException
requested changes
Apr 22, 2020
| @@ -63,6 +63,9 @@ protected function initialize(InputInterface $input, OutputInterface $output) : | |||
| ); | |||
| $connectionLoader = new ConfigurationFile((string) $input->getOption('db-configuration')); | |||
| $this->dependencyFactory = DependencyFactory::fromConnection($configurationLoader, $connectionLoader); | |||
| } elseif (is_string($input->getOption('configuration'))) { | |||
There was a problem hiding this comment.
Can you please call $input->getOption('configuration') once and use a variable?
| @@ -91,6 +91,7 @@ public function testConnection() : void | |||
|
|
|||
| self::assertSame($this->connection, $di->getConnection()); | |||
| self::assertFalse($di->hasEntityManager()); | |||
| self::assertTrue($di->isFrozen()); | |||
There was a problem hiding this comment.
Testing explicitly if the DependencyFactory. Does this mean that in the other tests it should be checked if it isn't frozen in case this is relevant for regressions?
alcaeus
approved these changes
Apr 23, 2020
goetas
force-pushed
the
allow-custom-configs-at-runtime
branch
from
f6ca1e8 to
2453b7e
Compare
|
@SenseException both notes you've left have been addressed in the last two commits |
greg0ire
approved these changes
Apr 23, 2020
SenseException
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the Dependency Factory contains already all the configurations.
This allows to change configurations (not db connection or entity manager) even if they are already specified in the Dependency Factory