Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move status info fetching into MigrationStatusInfosHelper #976

Merged
merged 1 commit into from
May 5, 2020

Conversation

goetas
Copy link
Member

@goetas goetas commented May 3, 2020

Q A
Type improvement
BC Break -
Fixed issues -

Summary

Move logic from the command class to the MigrationStatusInfosHelper to display the current migration status

@goetas goetas added this to the 3.0.0 milestone May 3, 2020
@goetas goetas changed the title Move status info fetching into MigrationStatusInfosHelper Move status info fetching into MigrationStatusInfosHelper May 3, 2020
@goetas goetas requested a review from greg0ire May 4, 2020 15:17
@greg0ire
Copy link
Member

greg0ire commented May 4, 2020

Please improve your commit message, the subject should be shorter than 50 chars, if you need more you can use the commit message body . Explaining why you are doing this in it would be nice too, something like "commands should be about handling CLI-related things" or whatever the actual reason for this is.

Move the logic for displaying the migration status from the command to the MigrationStatusInfosHelper, in this way the command does not need to be aware of the underlying dependencies.
@goetas
Copy link
Member Author

goetas commented May 5, 2020

done

Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@goetas goetas merged commit b724dcf into doctrine:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants