Re-enable alpha1 meaningful message when "latest" already reached.

[bugalot]

Q	A
Type	improvement
BC Break	no
Fixed issues	#987

Summary

Tries to fix the issue described in issue #987. To summarize, it is a proposal to get back the nice and clean "[WARNING] Already at latest version" when trying to perform a migration on a platform already at "latest" version.

[goetas]

Thanks for your contribution.

I'm ok with this change, I've left only one suggestion

[bugalot]

I implemented the suggested change. The message will be now like "Already at version "VERSION_ALIAS" ("VERSION")".

Thanks a lot for the review @goetas !

[jmsche]

Hi,

I'm just wondering if it makes sense to throw a warning/error if all migrations have been executed?

Also throwing a warning while passing the --allow-no-migration option seems weird to me as we explicitly allow it (eg. during deploy).

And thank you @bugalot for the message improvement :)

[elkuku]

Not sure why this isn't considered a BC break since it breaks CI without passing the (new) --allow-no-migration option :(

Please merge soon ;)

[greg0ire]

@elkuku what makes you say it is not considered a BC-break? This is version 3.0.0…

[greg0ire]

I'm just wondering if it makes sense to throw a warning/error if all migrations have been executed?

If all migrations have been executed, running the migrations command is a bit weird, and notifying the user about it makes sense IMO.

Also throwing a warning while passing the --allow-no-migration option seems weird to me as we explicitly allow it (eg. during deploy).

Good point, maybe it fits more the description for notice: https://github.com/php-fig/log/blob/master/Psr/Log/LoggerInterface.php#L82

[greg0ire]

Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble.

How to do that?

1. git rebase -i origin/master, assuming origin is a git remote that points to this repository, and not your fork. If you're not sure what your remotes are, run git remote -vvv, there should be your fork and the holy/reference/base/origin/whatever-you-call-it repository.
2. A window will show up with many lines, replace pick with fixup on every line but the first one
3. Close your editor, git should do its magic, and you should end up with one commit
4. Use git push --force to overwrite what you already push. Don't forget the --force option otherwise git will try to merge both things together.

[goetas]

Thanks!