Allow legacy cli-config.php configurations #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Jun 14, 2020
|
Should this be considered a Bugfix and target 3.0.1 or feature and go into 3.1.0? |
|
From the general feeling I get by reading the fixed issue I would say bugfix. |
goetas
force-pushed
the
allow-legacy-configs
branch
from
98bfc2c to
5c80ae8
Compare
goetas
changed the title
greg0ire
approved these changes
Jun 18, 2020
|
I ran into this issue as well. I did not see this in the docs anywhere, also it is impossible to use this with a custom configuration location due to $configurations = new ConfigurationFileWithFallback(); in checkLegacyConfiguration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow legacy configurations to improve interoperability with other doctrine cli tools.
This will read the helpersets and try to create from them the dependency factory