-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Defer removing removed entities from to-many collections until after …
…transaction commit
- Loading branch information
Showing
4 changed files
with
239 additions
and
61 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,157 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Doctrine\Tests\ORM\Functional; | ||
|
|
||
| use Doctrine\Common\Collections\ArrayCollection; | ||
| use Doctrine\Common\Collections\Collection; | ||
| use Doctrine\DBAL\Exception\ForeignKeyConstraintViolationException; | ||
| use Doctrine\ORM\Mapping as ORM; | ||
| use Doctrine\Tests\OrmFunctionalTestCase; | ||
|
|
||
| /** | ||
| * @Group GH10752 | ||
| */ | ||
| class GH10752Test extends OrmFunctionalTestCase | ||
| { | ||
| protected function setUp(): void | ||
| { | ||
| parent::setUp(); | ||
|
|
||
| $this->setUpEntitySchema([ | ||
| GH10752Order::class, | ||
| GH10752Promotion::class, | ||
| ]); | ||
| } | ||
|
|
||
| public function testThrowExceptionWhenRemovingPromotionThatIsInUse(): void | ||
| { | ||
| if (! $this->_em->getConnection()->getDatabasePlatform()->supportsForeignKeyConstraints()) { | ||
| self::markTestSkipped('Platform does not support foreign keys.'); | ||
| } | ||
|
|
||
| $order = $this->createOrder(); | ||
| $promotion = $this->createPromotion(); | ||
|
|
||
| $order->addPromotion($promotion); | ||
|
|
||
| $this->_em->persist($order); | ||
| $this->_em->persist($promotion); | ||
| $this->_em->flush(); | ||
|
|
||
| $this->_em->remove($promotion); | ||
|
|
||
| $this->expectException(ForeignKeyConstraintViolationException::class); | ||
| $this->_em->flush(); | ||
| } | ||
|
|
||
| public function testThrowExceptionWhenRemovingPromotionThatIsInUseAndOrderIsNotInMemory(): void | ||
| { | ||
| if (! $this->_em->getConnection()->getDatabasePlatform()->supportsForeignKeyConstraints()) { | ||
| self::markTestSkipped('Platform does not support foreign keys.'); | ||
| } | ||
|
|
||
| $order = $this->createOrder(); | ||
| $promotion = $this->createPromotion(); | ||
|
|
||
| $order->addPromotion($promotion); | ||
|
|
||
| $this->_em->persist($order); | ||
| $this->_em->persist($promotion); | ||
| $this->_em->flush(); | ||
|
|
||
| $this->_em->clear(); | ||
|
|
||
| $promotion = $this->_em->find(GH10752Promotion::class, $promotion->getId()); | ||
| $this->_em->remove($promotion); | ||
|
|
||
| $this->expectException(ForeignKeyConstraintViolationException::class); | ||
| $this->_em->flush(); | ||
| } | ||
|
|
||
| private function createOrder(): GH10752Order | ||
| { | ||
| return new GH10752Order(); | ||
| } | ||
|
|
||
| private function createPromotion(): GH10752Promotion | ||
| { | ||
| return new GH10752Promotion(); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * @ORM\Entity | ||
| */ | ||
| class GH10752Order | ||
| { | ||
| /** | ||
| * @ORM\Id | ||
| * @ORM\GeneratedValue | ||
| * @ORM\Column(type="integer") | ||
| * | ||
| * @var int | ||
| */ | ||
| private $id = null; | ||
|
|
||
| /** | ||
| * @ORM\ManyToMany(targetEntity="GH10752Promotion", cascade={"persist"}) | ||
| * @ORM\JoinTable(name="order_promotion", | ||
| * joinColumns={@ORM\JoinColumn(name="order_id", referencedColumnName="id", onDelete="CASCADE")}, | ||
| * inverseJoinColumns={@ORM\JoinColumn(name="promotion_id", referencedColumnName="id")} | ||
| * ) | ||
| * | ||
| * @var Collection | ||
| */ | ||
| private $promotions; | ||
|
|
||
| public function __construct() | ||
| { | ||
| $this->promotions = new ArrayCollection(); | ||
| } | ||
|
|
||
| public function getId(): ?int | ||
| { | ||
| return $this->id; | ||
| } | ||
|
|
||
| public function getPromotions(): Collection | ||
| { | ||
| return $this->promotions; | ||
| } | ||
|
|
||
| public function addPromotion(GH10752Promotion $promotion): void | ||
| { | ||
| if (! $this->promotions->contains($promotion)) { | ||
| $this->promotions->add($promotion); | ||
| } | ||
| } | ||
|
|
||
| public function removePromotion(GH10752Promotion $promotion): void | ||
| { | ||
| if ($this->promotions->contains($promotion)) { | ||
| $this->promotions->removeElement($promotion); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * @ORM\Entity | ||
| */ | ||
| class GH10752Promotion | ||
| { | ||
| /** | ||
| * @ORM\Id | ||
| * @ORM\GeneratedValue | ||
| * @ORM\Column(type="integer") | ||
| * | ||
| * @var int | ||
| */ | ||
| private $id = null; | ||
|
|
||
| public function getId(): ?int | ||
| { | ||
| return $this->id; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.