-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Skip joined entity creation for empty relation (#10889)
- Loading branch information
1 parent
59c8bc0
commit 3b49913
Showing
2 changed files
with
115 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,107 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace Doctrine\Tests\ORM\Functional\Ticket; | ||
|
||
use Doctrine\ORM\Mapping as ORM; | ||
use Doctrine\Tests\OrmFunctionalTestCase; | ||
|
||
/** | ||
* @see https://github.com/doctrine/orm/issues/10889 | ||
* | ||
* @group GH10889 | ||
*/ | ||
class GH10889Test extends OrmFunctionalTestCase | ||
{ | ||
protected function setUp(): void | ||
{ | ||
parent::setUp(); | ||
|
||
$this->createSchemaForModels( | ||
GH10889Person::class, | ||
GH10889Company::class, | ||
GH10889Resume::class | ||
); | ||
} | ||
|
||
public function testIssue(): void | ||
{ | ||
$person = new GH10889Person(); | ||
$resume = new GH10889Resume($person, null); | ||
|
||
$this->_em->persist($person); | ||
$this->_em->persist($resume); | ||
$this->_em->flush(); | ||
$this->_em->clear(); | ||
|
||
/** @var list<GH10889Resume> $resumes */ | ||
$resumes = $this->_em | ||
->getRepository(GH10889Resume::class) | ||
->createQueryBuilder('resume') | ||
->leftJoin('resume.currentCompany', 'company')->addSelect('company') | ||
->getQuery() | ||
->getResult(); | ||
|
||
$this->assertArrayHasKey(0, $resumes); | ||
$this->assertEquals(1, $resumes[0]->person->id); | ||
$this->assertNull($resumes[0]->currentCompany); | ||
} | ||
} | ||
|
||
/** | ||
* @ORM\Entity | ||
*/ | ||
class GH10889Person | ||
{ | ||
/** | ||
* @ORM\Id | ||
* @ORM\Column(type="integer") | ||
* @ORM\GeneratedValue | ||
* | ||
* @var int | ||
*/ | ||
public $id; | ||
} | ||
|
||
/** | ||
* @ORM\Entity | ||
*/ | ||
class GH10889Company | ||
{ | ||
/** | ||
* @ORM\Id | ||
* @ORM\Column(type="integer") | ||
* @ORM\GeneratedValue | ||
* | ||
* @var int | ||
*/ | ||
public $id; | ||
} | ||
|
||
/** | ||
* @ORM\Entity | ||
*/ | ||
class GH10889Resume | ||
{ | ||
/** | ||
* @ORM\Id | ||
* @ORM\OneToOne(targetEntity="GH10889Person") | ||
* | ||
* @var GH10889Person | ||
*/ | ||
public $person; | ||
|
||
/** | ||
* @ORM\ManyToOne(targetEntity="GH10889Company") | ||
* | ||
* @var GH10889Company|null | ||
*/ | ||
public $currentCompany; | ||
|
||
public function __construct(GH10889Person $person, ?GH10889Company $currentCompany) | ||
{ | ||
$this->person = $person; | ||
$this->currentCompany = $currentCompany; | ||
} | ||
} |