Skip to content

Commit

Permalink
Skip joined entity creation for empty relation (#10889)
Browse files Browse the repository at this point in the history
  • Loading branch information
noemi-salaun committed Jun 14, 2024
1 parent 59c8bc0 commit 3b49913
Show file tree
Hide file tree
Showing 2 changed files with 115 additions and 4 deletions.
12 changes: 8 additions & 4 deletions src/Internal/Hydration/ObjectHydrator.php
Original file line number Diff line number Diff line change
Expand Up @@ -367,11 +367,15 @@ protected function hydrateRowData(array $row, array &$result)
$parentObject = $this->resultPointers[$parentAlias];
} else {
// Parent object of relation not found, mark as not-fetched again
$element = $this->getEntity($data, $dqlAlias);
if (isset($nonemptyComponents[$dqlAlias])) {
$element = $this->getEntity($data, $dqlAlias);

// Update result pointer and provide initial fetch data for parent
$this->resultPointers[$dqlAlias] = $element;
$rowData['data'][$parentAlias][$relationField] = $element;
// Update result pointer and provide initial fetch data for parent
$this->resultPointers[$dqlAlias] = $element;
$rowData['data'][$parentAlias][$relationField] = $element;
} else {
$element = null;
}

// Mark as not-fetched again
unset($this->_hints['fetched'][$parentAlias][$relationField]);
Expand Down
107 changes: 107 additions & 0 deletions tests/Tests/ORM/Functional/Ticket/GH10889Test.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,107 @@
<?php

declare(strict_types=1);

namespace Doctrine\Tests\ORM\Functional\Ticket;

use Doctrine\ORM\Mapping as ORM;
use Doctrine\Tests\OrmFunctionalTestCase;

/**
* @see https://github.com/doctrine/orm/issues/10889
*
* @group GH10889
*/
class GH10889Test extends OrmFunctionalTestCase
{
protected function setUp(): void
{
parent::setUp();

$this->createSchemaForModels(
GH10889Person::class,
GH10889Company::class,
GH10889Resume::class
);
}

public function testIssue(): void
{
$person = new GH10889Person();
$resume = new GH10889Resume($person, null);

$this->_em->persist($person);
$this->_em->persist($resume);
$this->_em->flush();
$this->_em->clear();

/** @var list<GH10889Resume> $resumes */
$resumes = $this->_em
->getRepository(GH10889Resume::class)
->createQueryBuilder('resume')
->leftJoin('resume.currentCompany', 'company')->addSelect('company')
->getQuery()
->getResult();

$this->assertArrayHasKey(0, $resumes);
$this->assertEquals(1, $resumes[0]->person->id);
$this->assertNull($resumes[0]->currentCompany);
}
}

/**
* @ORM\Entity
*/
class GH10889Person
{
/**
* @ORM\Id
* @ORM\Column(type="integer")
* @ORM\GeneratedValue
*
* @var int
*/
public $id;
}

/**
* @ORM\Entity
*/
class GH10889Company
{
/**
* @ORM\Id
* @ORM\Column(type="integer")
* @ORM\GeneratedValue
*
* @var int
*/
public $id;
}

/**
* @ORM\Entity
*/
class GH10889Resume
{
/**
* @ORM\Id
* @ORM\OneToOne(targetEntity="GH10889Person")
*
* @var GH10889Person
*/
public $person;

/**
* @ORM\ManyToOne(targetEntity="GH10889Company")
*
* @var GH10889Company|null
*/
public $currentCompany;

public function __construct(GH10889Person $person, ?GH10889Company $currentCompany)
{
$this->person = $person;
$this->currentCompany = $currentCompany;
}
}

0 comments on commit 3b49913

Please sign in to comment.