Skip to content

Commit

Permalink
Remove disconnected class metadata factory
Browse files Browse the repository at this point in the history
It is unused apart from a tests where it is easily replaced.
  • Loading branch information
greg0ire committed May 1, 2022
1 parent 8353e98 commit 467bc6f
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 32 deletions.
4 changes: 4 additions & 0 deletions UPGRADE.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Upgrade to 3.0

## BC BREAK: Remove `Doctrine\ORM\Tools\DisconnectedClassMetadataFactory`

No replacement is provided.

## BC BREAK: Remove support for `Type::canRequireSQLConversion()`

This feature was deprecated in DBAL 3.3.0 and will be removed in DBAL 4.0.
Expand Down
29 changes: 0 additions & 29 deletions lib/Doctrine/ORM/Tools/DisconnectedClassMetadataFactory.php

This file was deleted.

6 changes: 3 additions & 3 deletions tests/Doctrine/Tests/ORM/Tools/Console/MetadataFilterTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@

namespace Doctrine\Tests\ORM\Tools\Console;

use Doctrine\ORM\Mapping\ClassMetadataFactory;
use Doctrine\ORM\Mapping\Column;
use Doctrine\ORM\Mapping\Entity;
use Doctrine\ORM\Mapping\Id;
use Doctrine\ORM\Tools\Console\MetadataFilter;
use Doctrine\ORM\Tools\DisconnectedClassMetadataFactory;
use Doctrine\Tests\OrmTestCase;

use function count;
Expand All @@ -20,7 +20,7 @@
*/
class MetadataFilterTest extends OrmTestCase
{
/** @var DisconnectedClassMetadataFactory */
/** @var ClassMetadataFactory */
private $cmf;

protected function setUp(): void
Expand All @@ -32,7 +32,7 @@ protected function setUp(): void

$em->getConfiguration()->setMetadataDriverImpl($driver);

$this->cmf = new DisconnectedClassMetadataFactory();
$this->cmf = new ClassMetadataFactory();
$this->cmf->setEntityManager($em);
}

Expand Down

0 comments on commit 467bc6f

Please sign in to comment.