Don't call deprecated getSQLResultCasing when we know the platform

doctrine · Jun 5, 2023 · 564c434 · 564c434
1 parent 2afe2dc
commit 564c434
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 0 deletions.
diff --git a/lib/Doctrine/ORM/Internal/SQLResultCasing.php b/lib/Doctrine/ORM/Internal/SQLResultCasing.php
@@ -6,8 +6,12 @@
 
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 use Doctrine\DBAL\Platforms\DB2Platform;
+use Doctrine\DBAL\Platforms\MySQLPlatform;
+use Doctrine\DBAL\Platforms\MySqlPlatform as LegacyMySqlPlatform;
 use Doctrine\DBAL\Platforms\OraclePlatform;
 use Doctrine\DBAL\Platforms\PostgreSQLPlatform;
+use Doctrine\DBAL\Platforms\SqlitePlatform;
+use Doctrine\DBAL\Platforms\SQLServerPlatform;
 
 use function method_exists;
 use function strtolower;
@@ -26,6 +30,11 @@ private function getSQLResultCasing(AbstractPlatform $platform, string $column):
             return strtolower($column);
         }
 
+        /** @psalm-suppress UndefinedClass, InvalidClass */
+        if ($platform instanceof LegacyMySqlPlatform || $platform instanceof MySQLPlatform || $platform instanceof SQLServerPlatform || $platform instanceof SqlitePlatform) {
+            return $column;
+        }
+
         if (method_exists(AbstractPlatform::class, 'getSQLResultCasing')) {
             return $platform->getSQLResultCasing($column);
         }

diff --git a/phpstan-dbal2.neon b/phpstan-dbal2.neon
@@ -10,6 +10,7 @@ parameters:
         - '/Call to an undefined method Doctrine\\DBAL\\Connection::createSchemaManager\(\)\./'
         # Class name will change in DBAL 3.
         - '/^Class Doctrine\\DBAL\\Platforms\\PostgreSQLPlatform not found\.$/'
+        - '/Doctrine\\DBAL\\Platforms\\MySqlPlatform\w/'
 
         # Forward compatibility for DBAL 3.5
         - '/^Call to an undefined method Doctrine\\DBAL\\Platforms\\AbstractPlatform::getAlterSchemaSQL\(\).$/'

diff --git a/phpstan-persistence2.neon b/phpstan-persistence2.neon
@@ -14,6 +14,7 @@ parameters:
 
         - '/^Class Doctrine\\DBAL\\Platforms\\SQLAnywherePlatform not found\.$/'
         - '/^Call to method \w+\(\) on an unknown class Doctrine\\DBAL\\Platforms\\SQLAnywherePlatform\.$/'
+        - '/Doctrine\\DBAL\\Platforms\\MySqlPlatform\w/'
 
         -
         	message: '/^Call to an undefined method Doctrine\\DBAL\\Platforms\\AbstractPlatform::getSQLResultCasing\(\)\.$/'

diff --git a/phpstan.neon b/phpstan.neon
@@ -14,6 +14,7 @@ parameters:
 
         - '/^Class Doctrine\\DBAL\\Platforms\\SQLAnywherePlatform not found\.$/'
         - '/^Call to method \w+\(\) on an unknown class Doctrine\\DBAL\\Platforms\\SQLAnywherePlatform\.$/'
+        - '/Doctrine\\DBAL\\Platforms\\MySqlPlatform\w/'
 
         -
         	message: '/^Call to an undefined method Doctrine\\DBAL\\Platforms\\AbstractPlatform::getSQLResultCasing\(\)\.$/'