#6613 #6614 #6616 removing repeated PersistentCollectionTest chunk…

…s of code
doctrine · Aug 11, 2017 · 61cb03b · 61cb03b
1 parent d6bcb5b
commit 61cb03b
Showing 1 changed file with 2 additions and 13 deletions.
diff --git a/tests/Doctrine/Tests/ORM/PersistentCollectionTest.php b/tests/Doctrine/Tests/ORM/PersistentCollectionTest.php
@@ -34,6 +34,8 @@ protected function setUp()
         parent::setUp();
 
         $this->_emMock = EntityManagerMock::create(new ConnectionMock([], new DriverMock()));
+
+        $this->setUpPersistentCollection();
     }
 
     /**
@@ -60,7 +62,6 @@ public function testCanBePutInLazyLoadingMode()
      */
     public function testCurrentInitializesCollection()
     {
-        $this->setUpPersistentCollection();
         $this->collection->current();
         $this->assertTrue($this->collection->isInitialized());
     }
@@ -70,7 +71,6 @@ public function testCurrentInitializesCollection()
      */
     public function testKeyInitializesCollection()
     {
-        $this->setUpPersistentCollection();
         $this->collection->key();
         $this->assertTrue($this->collection->isInitialized());
     }
@@ -80,7 +80,6 @@ public function testKeyInitializesCollection()
      */
     public function testNextInitializesCollection()
     {
-        $this->setUpPersistentCollection();
         $this->collection->next();
         $this->assertTrue($this->collection->isInitialized());
     }
@@ -90,8 +89,6 @@ public function testNextInitializesCollection()
      */
     public function testRemovingElementsAlsoRemovesKeys()
     {
-        $this->setUpPersistentCollection();
-
         $dummy = new \stdClass();
 
         $this->collection->add($dummy);
@@ -106,8 +103,6 @@ public function testRemovingElementsAlsoRemovesKeys()
      */
     public function testClearWillAlsoClearKeys()
     {
-        $this->setUpPersistentCollection();
-
         $this->collection->add(new \stdClass());
         $this->collection->clear();
         $this->assertEquals([], array_keys($this->collection->toArray()));
@@ -118,8 +113,6 @@ public function testClearWillAlsoClearKeys()
      */
     public function testClearWillAlsoResetKeyPositions()
     {
-        $this->setUpPersistentCollection();
-
         $dummy = new \stdClass();
 
         $this->collection->add($dummy);
@@ -141,8 +134,6 @@ public function testWillKeepNewItemsInDirtyCollectionAfterInitialization()
 
         $this->_emMock->setUnitOfWork($unitOfWork);
 
-        $this->setUpPersistentCollection();
-
         $newElement       = new \stdClass();
         $persistedElement = new \stdClass();
 
@@ -178,8 +169,6 @@ public function testWillDeDuplicateNewItemsThatWerePreviouslyPersistedInDirtyCol
 
         $this->_emMock->setUnitOfWork($unitOfWork);
 
-        $this->setUpPersistentCollection();
-
         $newElement                    = new \stdClass();
         $newElementThatIsAlsoPersisted = new \stdClass();
         $persistedElement              = new \stdClass();