Skip to content

Commit

Permalink
#6464 #6475 using PHP 7.1 void and string return hints where avai…
Browse files Browse the repository at this point in the history
…lable
  • Loading branch information
Ocramius committed Aug 11, 2017
1 parent 91a5091 commit 9ad91dd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/Doctrine/ORM/Query/SqlWalker.php
Original file line number Diff line number Diff line change
Expand Up @@ -888,7 +888,7 @@ public function walkRangeVariableDeclaration($rangeVariableDeclaration)
*
* @return string
*/
private function generateRangeVariableDeclarationSQL($rangeVariableDeclaration, $buildNestedJoins)
private function generateRangeVariableDeclarationSQL($rangeVariableDeclaration, bool $buildNestedJoins) : string
{
$class = $this->em->getClassMetadata($rangeVariableDeclaration->abstractSchemaName);
$dqlAlias = $rangeVariableDeclaration->aliasIdentificationVariable;
Expand Down
4 changes: 2 additions & 2 deletions tests/Doctrine/Tests/ORM/Functional/Ticket/GH6464Test.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class GH6464Test extends OrmFunctionalTestCase
/**
* {@inheritDoc}
*/
protected function setUp()
protected function setUp() : void
{
parent::setUp();

Expand All @@ -29,7 +29,7 @@ protected function setUp()
* SqlWalker needs to generate nested INNER JOIN statements, otherwise there would be INNER JOIN
* statements without an ON clause, which are valid on e.g. MySQL but rejected by PostgreSQL.
*/
public function testIssue()
public function testIssue() : void
{
$query = $this->_em->createQueryBuilder()
->select('p')
Expand Down

0 comments on commit 9ad91dd

Please sign in to comment.