Throw an exception when the inverse side configures the join column(s)

doctrine · Apr 25, 2023 · c870020 · c870020
1 parent ba9f51a
commit c870020
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php b/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php
@@ -1864,8 +1864,8 @@ protected function _validateAndCompleteOneToOneMapping(array $mapping)
     {
         $mapping = $this->_validateAndCompleteAssociationMapping($mapping);
 
-        if (isset($mapping['joinColumns']) && $mapping['joinColumns']) {
-            $mapping['isOwningSide'] = true;
+        if (isset($mapping['joinColumns']) && $mapping['joinColumns'] && ! $mapping['isOwningSide']) {
+            throw MappingException::joinColumnNotAllowedOnInverseSide($this->name, $mapping['fieldName']);
         }
 
         if ($mapping['isOwningSide']) {

diff --git a/lib/Doctrine/ORM/Mapping/MappingException.php b/lib/Doctrine/ORM/Mapping/MappingException.php
@@ -345,6 +345,11 @@ public static function joinColumnMustPointToMappedField($className, $joinColumn)
         ));
     }
 
+    public static function joinColumnNotAllowedOnInverseSide(string $className, string $fieldName): self
+    {
+        return new self(sprintf('The %s#%s field is not the owning side of the association, so it may not configure join column(s)', $className, $fieldName));
+    }
+
     /**
      * @param class-string $className
      *
-Original file line number
+Diff line change
@@ Expand Up @@
             ));
         }
+        public static function joinColumnNotAllowedOnInverseSide(string $className, string $fieldName): self
+        {
+            return new self(sprintf('The %s#%s field is not the owning side of the association, so it may not configure join column(s)', $className, $fieldName));
+        }
         /**
          * @param class-string $className
          *
@@ Expand Down @@