-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow dumping SQL query when passing DQL on cli
- Loading branch information
Showing
1 changed file
with
9 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdb62a7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, but you've broken the DQL command. The input always has the option show-sql, whether or not it is set or not, as it checks if the InputOption object exists in the InputDefinition. I will create an PR any minute.
cdb62a7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bobvandevijver please be respectful of other contributor's work: nobody really meant to break it on purpose.
cdb62a7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I accidentally missed a word (but), so I've updated the comment. It was never meant to be disrespectful.
cdb62a7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bobvandevijver thanks for clarifying. Wording is indeed much better now ;-)