Validate XML mapping against XSD file

doctrine · Sep 25, 2017 · e71713a · e71713a
1 parent 1d5c87e
commit e71713a
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 0 deletions.
diff --git a/lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php b/lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php
@@ -837,6 +837,7 @@ private function _getCascadeMappings(SimpleXMLElement $cascadeElement)
      */
     protected function loadMappingFile($file)
     {
+        $this->assertValid($file);
         $result = [];
         // Note: we do not use `simplexml_load_file()` because of https://bugs.php.net/bug.php?id=62577
         $xmlElement = simplexml_load_string(file_get_contents($file));
@@ -861,6 +862,21 @@ protected function loadMappingFile($file)
         return $result;
     }
 
+    private function assertValid(string $file): void
+    {
+        $backedUpErrorSetting = libxml_use_internal_errors(true);
+        $document = new \DOMDocument();
+        $document->load($file);
+        if (!$document->schemaValidate(__DIR__ . '/../../../../../doctrine-mapping.xsd')) {
+            $errors = libxml_get_errors();
+            libxml_clear_errors();
+            libxml_use_internal_errors(false);
+            throw MappingException::fromLibXmlErrors($errors);
+        }
+        libxml_clear_errors();
+        libxml_use_internal_errors(false);
+    }
+
     /**
      * @param mixed $element
      *

diff --git a/lib/Doctrine/ORM/Mapping/MappingException.php b/lib/Doctrine/ORM/Mapping/MappingException.php
@@ -820,4 +820,21 @@ public static function infiniteEmbeddableNesting($className, $propertyName)
             )
         );
     }
+
+    /**
+     * @param LibXMLError[] $errors
+     */
+    public static function fromLibXmlErrors(array $errors) : self
+    {
+        return new self(array_reduce(array_map(function (\LibXMLError $error) : string {
+            return sprintf(
+                'libxml error: %s%s:%d',
+                $error->message,
+                $error->file,
+                $error->line
+            );
+        }, $errors), function ($previousMessage, $currentMessage) : string {
+            return $previousMessage . PHP_EOL . $currentMessage;
+        }, ''));
+    }
 }