DDC-3259: Second level & UnitOfWork inconsistencies

[doctrinebot]

Jira issue originally created by user goetas:

Hi!

I have a lot of entities with entity associations as keys and I'm trying to use second level cache.

Looking at the method: UnitOfWork::createEntity($className, array $data, &$hints = array())

• $className: contains the class name
• $data: contains the raw data (the row coming from the database)

Enabling the second level cache, DefaultQueryCache::get calls the createEntity method passing a $data that contains object entities and some raw data (https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Cache/DefaultQueryCache.php#L155).

I think that DefaultQueryCache should not introduce a variant of $data and should create a compatible version of $data.

[doctrinebot]

Comment created by @Ocramius:

[~goetas] do you have any example of where this may be happening?

[doctrinebot]

Comment created by goetas:

#1114

This is the same branch of #1113, plus this commit (goetas@bfbbb91) that simply involves the second level cache too.
Travis should fail soon.

[doctrinebot]

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1114] was closed:
#1114

[doctrinebot]

Comment created by goetas:

Here the failure https://travis-ci.org/doctrine/doctrine2/jobs/32972996#L402

[doctrinebot]

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1113] was assigned:
#1113

[doctrinebot]

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1113] was closed:
#1113

[doctrinebot]

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1113] was labeled:
#1113

[doctrinebot]

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1113] was labeled:
#1113

[doctrinebot]

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1113] was closed:
#1113

[lcobucci]

Looks like it was fixed on #1113 (which was merged manually).