Composite pk break test #1114
Composite pk break test #1114
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3260 We use Jira to track the state of pull requests and the versions they got |
| if (isset($this->class->fieldMappings[$field]['requireSQLConversion'])) { | ||
| $placeholder = Type::getType($this->class->getTypeOfField($field))->convertToDatabaseValueSQL($placeholder, $this->platform); | ||
| if (count($columns)>1 && $comparison === Comparison::IN){ | ||
| throw ORMException::cantUseInOperatorOnCompositeKeys(); |
There was a problem hiding this comment.
In reality, you can... =)
SELECT ... FROM ... WHERE (id1, id2) IN (('cpk1.1', 'cpk1.2'), ('cpk2.1', 'cpk2.2'), ...);There was a problem hiding this comment.
Is this SQL standard? Sqlite seems that does not support this
There was a problem hiding this comment.
Uhm... is that cross-db compatible?
There was a problem hiding this comment.
It is... in SQLite, you can follow these rules:
select-stmt: ... WHERE expr
expr: "(" expr ")" | in-expr
in-expr: expr [ "NOT" ] "IN" ( [ database-name "." ] table-name | "(" ( select-stmt | { expr "," }* ) ")" )
There was a problem hiding this comment.
I don't see where the nested parenthesis are in there. See for example http://stackoverflow.com/a/11171387/347063
There was a problem hiding this comment.
Then it's either a bug in their grammar or their support. Based on their SQL grammar, it is supported.
There was a problem hiding this comment.
@guilhermeblanco given the amount of effort that we put in fixing SQLServer's shit (pardon the terminology: comes from frustration) I don't think this is a valid argument anymore :P
We support what is supported by all storage layers, not what the standard supports.
|
@guilhermeblanco I'm sorry, but I have created this PR only to clarify http://www.doctrine-project.org/jira/browse/DDC-3259 |
| $className = (isset($this->class->associationMappings[$field]['inherited'])) | ||
| ? $this->class->associationMappings[$field]['inherited'] | ||
| : $this->class->name; | ||
|
|
||
| return $this->getSQLTableAlias($className) . '.' . $this->quoteStrategy->getJoinColumnName($joinColumn, $this->class, $this->platform); | ||
| $columns = array(); | ||
| foreach ($this->class->associationMappings[$field]['joinColumns'] as $joinColumn) { |
|
This is the real PR #1113 |
| @@ -1741,79 +1757,86 @@ public function expandParameters($criteria) | |||
| continue; // skip null values. | |||
| } | |||
|
|
|||
| $types[] = $this->getType($field, $value); | |||
| $params[] = $this->getValue($value); | |||
| $types = array_merge($types, $this->getTypes($field, $value)); | |||
| $class = $this->em->getClassMetadata(ClassUtils::getClass($value)); | ||
| if ($class->isIdentifierComposite) { | ||
| $newValue = array(); | ||
| foreach ($class->getIdentifierValues($value) as $innerValue) { |
|
@goetas AAHH... sorry then! =) |
| * | ||
| * @throws \Doctrine\ORM\ORMException | ||
| */ | ||
| protected function getSelectConditionStatementColumnSQL($field, $assoc = null) | ||
| private function getSelectConditionStatementColumnSQL($field, $assoc = null) |
No description provided.