-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli-config.php compatibility with DBAL #8327
Labels
Milestone
Comments
This was referenced Nov 4, 2020
beberlei
added a commit
to beberlei/doctrine2
that referenced
this issue
Mar 6, 2021
2 tasks
beberlei
added a commit
to beberlei/doctrine2
that referenced
this issue
Mar 6, 2021
… instead of HelperSet.
beberlei
added a commit
to beberlei/doctrine2
that referenced
this issue
Mar 6, 2021
… instead of HelperSet.
beberlei
added a commit
to beberlei/doctrine2
that referenced
this issue
Mar 6, 2021
… instead of HelperSet.
I have updated the description of the issue to explain my approach to performing this deprecation:
|
beberlei
added a commit
to beberlei/doctrine2
that referenced
this issue
Mar 28, 2021
beberlei
added a commit
to beberlei/doctrine2
that referenced
this issue
Apr 10, 2021
beberlei
added a commit
to beberlei/doctrine2
that referenced
this issue
Apr 11, 2021
beberlei
added a commit
to beberlei/doctrine2
that referenced
this issue
Apr 11, 2021
…ency with DoctrineBundle.
beberlei
added a commit
to beberlei/doctrine2
that referenced
this issue
Apr 18, 2021
beberlei
added a commit
to beberlei/doctrine2
that referenced
this issue
Apr 18, 2021
beberlei
added a commit
to beberlei/doctrine2
that referenced
this issue
Apr 18, 2021
beberlei
added a commit
that referenced
this issue
Apr 18, 2021
…8524) * cli config * [GH-8327] Deprecate EntityManager HelperSet for a provider abstraction. * Housekeeping: phpcs * [GH-8327] Refactor tests towards use of SingleManagerProvider instead of HelperSet. * [GH-8327] Refactor tests towards use of SingleManagerProvider instead of HelperSet. * [GH-8327] Refactor tests towards use of SingleManagerProvider instead of HelperSet. * Housekeeping: cs * Update tests/Doctrine/Tests/ORM/Tools/Console/ConsoleRunnerTest.php Co-authored-by: Grégoire Paris <[email protected]> * [GH-8327] Change option from entity-manager to em for consistency with DoctrineBundle. * Add final to new methods and classes Co-authored-by: Grégoire Paris <[email protected]> * [GH-8327] Bugfix: phpstan detected stricter type checks needed. * phpcs Co-authored-by: Grégoire Paris <[email protected]>
Merged #8524 into 2.9.x |
beberlei
added a commit
to beberlei/doctrine2
that referenced
this issue
Apr 20, 2021
… DoctrineBundle usage.
beberlei
added a commit
to beberlei/doctrine2
that referenced
this issue
Apr 25, 2021
…r in ConnectionFromManagerProvider
beberlei
added a commit
that referenced
this issue
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since DBAL 2.11.0 and doctrine/dbal#3956, it is now deprecated to use HelperSet in
cli-config.php
. This will become impossible in DBAL 3, following doctrine/dbal#4059.This means that, in order to keep sharing a single config file for both packages, this package should also accept the new
\Doctrine\DBAL\Tools\Console\ConnectionProvider
. It could actually be a new interface along the lines of:I suppose the support of HelperSet could be drop entirely in the next major version too. So long we can use a
HelperSetManagerProvider
that extends theEntityManagerProvider
.All commands must be adjusted to access the entity manager from a provider instead of the HelperSet. Deprecation messages when using HelperSet must be thrown appropriately.
See related doctrine/migrations#1070
The text was updated successfully, but these errors were encountered: