Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QueryBuilder function "createNamedParameter" like in doctrine/dbal #9878

Open
Digi92 opened this issue Jul 3, 2022 · 1 comment
Open

QueryBuilder function "createNamedParameter" like in doctrine/dbal #9878

Digi92 opened this issue Jul 3, 2022 · 1 comment
Labels
New Feature

Comments

@Digi92
Copy link

Digi92 commented Jul 3, 2022

Feature Request

Hello,
i noticed that the function "createNamedParameter" does not exist in the QueryBuilder, unlike the QueryBuilder from "doctrine/dbal".
Is there a reason why it is not available in "doctrine/orm"?
Otherwise I can create a pull request.

Q A
New Feature yes
RFC no
BC Break no

Summary

Documentation of the function "createNamedParameter": https://www.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/query-builder.html#binding-parameters-to-placeholders
@greg0ire greg0ire mentioned this issue Jul 4, 2022
Merged
@greg0ire
Copy link
Member

greg0ire commented Jul 4, 2022

I don't know why it wasn't added, but if we were to add createNamedParameter, I think it would make sense to add createPositionalParameter as well, wouldn't it?

Personally, I've never used createNamedParameter, I don't have an opinion for or against it right now.

Digi92 added a commit to Digi92/orm that referenced this issue Jul 6, 2022
@Digi92
Added the functions "createNamedParameter" and "createPositionalParam…
00986f9 
…eter" to the class "QueryBuilder"

The two functions "createNamedParameter" and "createPositionalParameter", from the "QueryBuilder" in the package "doctrine/dbal", copied into the ORM "QueryBuilder" class and adapted to ORM.

doctrineGH-9878
@Digi92 Digi92 mentioned this issue Jul 7, 2022
Closed
Digi92 added a commit to Digi92/orm that referenced this issue Jul 7, 2022
@Digi92
Fix param annotation type for "createNamedParameter" and "createNamed…
448129c 
…Parameter" to the class "QueryBuilder"

doctrineGH-9878
Digi92 added a commit to Digi92/orm that referenced this issue Jul 7, 2022
@Digi92
Fix spacing for param annotation type for "createNamedParameter" and …
4ee2ae8 
…"createNamedParameter" to the class "QueryBuilder"

doctrineGH-9878
Digi92 added a commit to Digi92/orm that referenced this issue Jul 12, 2022
@Digi92
Added the functions "createNamedParameter" and "createPositionalParam…
f38a9b8 
…eter" to the class "QueryBuilder"

The two functions "createNamedParameter" and "createPositionalParameter", from the "QueryBuilder" in the package "doctrine/dbal", copied into the ORM "QueryBuilder" class and adapted to ORM.

doctrineGH-9878
Digi92 added a commit to Digi92/orm that referenced this issue Jul 12, 2022
@Digi92
Fix param annotation type for "createNamedParameter" and "createNamed…
182cdf7 
…Parameter" to the class "QueryBuilder"

doctrineGH-9878
Digi92 added a commit to Digi92/orm that referenced this issue Jul 12, 2022
@Digi92
Fix spacing for param annotation type for "createNamedParameter" and …
55614ef 
…"createNamedParameter" to the class "QueryBuilder"

doctrineGH-9878
Digi92 added a commit to Digi92/orm that referenced this issue Jul 12, 2022
@Digi92
Replace default parameter with native version for functions "createNa…
8dcd798 
…medParameter" and "createNamedParameter" in the class "QueryBuilder"

doctrineGH-9878
norkunas pushed a commit to norkunas/orm that referenced this issue Jun 27, 2024
@Digi92 @norkunas
Add tests for "createNamedParameter" and "createPositionalParameter"
b075a88 
doctrineGH-9878
norkunas pushed a commit to norkunas/orm that referenced this issue Jun 27, 2024
@Digi92 @norkunas
Add tests for "createNamedParameter" and "createPositionalParameter"
86c4f68 
doctrineGH-9878
norkunas pushed a commit to norkunas/orm that referenced this issue Jun 27, 2024
@Digi92 @norkunas
Add tests for "createNamedParameter" and "createPositionalParameter"
cfdad4e 
doctrineGH-9878
@norkunas norkunas mentioned this issue Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
New Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@greg0ire @derrabus @Digi92