Fail gracefully if EM could not be constructed in tests #10008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Aug 27, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Aug 30, 2022
* 2.14.x: Bump Ubuntu version and shared workflows (doctrine#10020) Make paginator covariant (doctrine#10002) Fail gracefully if EM could not be constructed in tests (doctrine#10008)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our functional test hooks into test failures. Here, the method
isQueryLogAvailable()is called which assumes that the entity manager had been constructed by the setUp method. However, if constructing the EM fails (for whatever reason) or the test fails even earlier, we will run into a null pointer here and we won't see the actual test failure. This PR fixes that problem.