Infer types in OneToManyPersister::deleteEntityCollection
#10075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
requested changes
Oct 26, 2022
| $updates = $conn->getExecuteStatements(); | ||
| $lastStatement = array_pop($updates); | ||
|
|
||
| self::assertSame('DELETE FROM onetomanypersister_child WHERE parent_id = ?', $lastStatement['sql']); |
There was a problem hiding this comment.
Suggested change
| self::assertSame('DELETE FROM onetomanypersister_child WHERE parent_id = ?', $lastStatement['sql']); | |
| self::assertSame('DELETE FROM onetomanypersister_child WHERE parent_id = ?', $lastStatement['sql']); |
Running assertions on generated SQL is always brittle. We should run the test against a real database and assert that the given record has been deleted properly.
There was a problem hiding this comment.
There was no tests at all for this persister,so I've just copied from another one and adapted it.. will see If I could manage to add a better one.. Do you have any suggestions where I should add it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #8401
In our app we are using Symfony Uuid and when collection needs to be cleared the deletion query is executed without types therefore Uuid casts to string instead of to binary and no relations are deleted.