Identity map cannot contains null value #10156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do you maybe need to update the psalm baseline? |
PowerKiKi
force-pushed
the
identity-map
branch
2 times, most recently
from
3c0eb42 to
6864377
Compare
|
psalm baseline updated and rebased on top of latest 2.13.x |
greg0ire
previously approved these changes
Oct 25, 2022
|
I'm not super familiar with psalm, but I think the failing CI is not related to my changes. Let me know if I should do something more... |
|
An easy to figure it out is to run I haven't seen this failure on other recent PRs, so I wouldn't be so sure if I were you. Not that you seem very sure 😛 |
|
You want to give this another try? |
PowerKiKi
force-pushed
the
identity-map
branch
from
6864377 to
6325591
Compare
|
Thanks for the reminder. I rebased on top of 2.14.x. It should be mergeable now. |
greg0ire
force-pushed
the
identity-map
branch
from
6325591 to
e17bcb2
Compare
|
Retargeted to 2.15.x since this is |
|
Also, I updated the Psalm baseline. |
greg0ire
approved these changes
Jan 20, 2023
derrabus
approved these changes
Jan 22, 2023
This was referenced Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduce psalm errors/warnings count