Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document property as non-nullable #10224

Merged
merged 1 commit into from
Nov 13, 2022
Merged

Document property as non-nullable #10224

merged 1 commit into from
Nov 13, 2022

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Nov 11, 2022 •
edited
Loading

The constructor forbids it.

@derrabus derrabus mentioned this pull request Nov 11, 2022
Merged
@greg0ire
Document property as non-nullable
6c7a5e6 
The constructor forbids it.
@greg0ire greg0ire changed the base branch from 2.13.x to 2.14.x November 11, 2022 17:43
@greg0ire greg0ire changed the title Document possibly null parameter Document property as non-nullable Nov 11, 2022
@greg0ire
Copy link
Member Author

@derrabus I retargeted to 2.14.x because the |null part is technically true.

@greg0ire greg0ire requested a review from derrabus November 11, 2022 17:53
@greg0ire greg0ire marked this pull request as ready for review November 11, 2022 17:53
@greg0ire greg0ire enabled auto-merge November 12, 2022 09:27
SenseException
SenseException approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To what |null are you referring to?

@greg0ire greg0ire merged commit ad69810 into doctrine:2.14.x Nov 13, 2022
@greg0ire greg0ire deleted the fix-wrong-phpdoc branch November 13, 2022 21:53
@greg0ire
Copy link
Member Author

@SenseException it was something added by Rector on https://github.com/doctrine/orm/pull/10219/files#r1020406559 to the type based on this = null I just removed. I was persuaded it was already on lower branches but as it turns out, only the = null was there 😅 Anyway, the PR is still valid 👍

@derrabus derrabus added this to the 2.14.0 milestone Nov 21, 2022
@github-actions github-actions bot mentioned this pull request Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
Static Analysis
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@greg0ire @SenseException @derrabus