Added warning about query cache in relation to parameters #10276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This warning indeed feels a bit redundant, given that the paragraph above it already explains how parameters should be dealt with. Maybe we can rephrase the existing paragraph instead of adding that warning? |
|
Hi @derrabus, Instead of the paragraph "Parameters for the query should be set..." "For the filter to correctly function the following rules must be followed, failure to do so will lead to unexpected results from the query cache.
The |
|
Yeah, something like that. Can you adjust the PR? |
SenseException
requested changes
Dec 19, 2022
Co-authored-by: Claudio Zizza <[email protected]>
Co-authored-by: Claudio Zizza <[email protected]>
SenseException
approved these changes
Dec 24, 2022
|
Thank you @antman3351 |
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Dec 28, 2022
* 2.15.x: Support of NOT expression from doctrine/collections ^2.1 (doctrine#10234) Fix Psalm errors with Collection 2.1.2 (doctrine#10343) Added warning about query cache in relation to parameters (doctrine#10276)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
It's probably not worded the best but I felt the need to add a warning in the docs about the query cache to hopefully help others not make the same mistake I did.
Although the docs do state: "Parameters for the query should be set on the filter object by
SQLFilter#setParameter(). Only parameters set via this function can be used in filters" I think it's not quite clear why and if developing with the query cache off can lead to hard to find bugs later on.