DDC-3123 extra updates cleanup #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3124 We use Jira to track the state of pull requests and the versions they got |
|
👍 looks good to me |
deeky666
added a commit
that referenced
this pull request
May 14, 2014
…cleanup DDC-3123 extra updates cleanup
|
Thank you for quick fix. |
|
|
||
| $extraUpdatesReflection->setAccessible(true); | ||
|
|
||
| $test->assertEmpty($extraUpdatesReflection->getValue($uow)); |
There was a problem hiding this comment.
To simplify this code and avoid using of reflections you can use function assertAttributeEmpty.
http://apidoc.phpunit.de/classes/PHPUnit_Framework_Assert/assertAttributeEmpty.html
There was a problem hiding this comment.
Done @91df8f5649b33d0c3bb50b04c66e1c00bf345df5
This was referenced Dec 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See DDC-3123 ( http://www.doctrine-project.org/jira/browse/DDC-3123 )
Extra updates in the UoW should be cleared immediately.