Migrate remaining exceptions to PHP 8 syntax #10402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
previously approved these changes
Jan 14, 2023
| */ | ||
| public static function newEntityFoundThroughRelationship(array $associationMapping, $entry) | ||
| /** @psalm-param array<string, string> $associationMapping */ | ||
| public static function newEntityFoundThroughRelationship(array $associationMapping, object $entry): ORMInvalidArgumentException |
There was a problem hiding this comment.
Suggested change
| public static function newEntityFoundThroughRelationship(array $associationMapping, object $entry): ORMInvalidArgumentException | |
| public static function newEntityFoundThroughRelationship(array $associationMapping, object $entry): self |
Can we enforce this via PHPCS, btw?
There was a problem hiding this comment.
@kukulich hi 👋 ! Would you maybe know about this?
There was a problem hiding this comment.
I think it's solved by Squiz.Classes.SelfMemberReference
There was a problem hiding this comment.
Hmm, probably not, because the sniff is used in Doctrine CS :(
There was a problem hiding this comment.
It looks I'll have to write the sniff :)
| * @return ORMInvalidArgumentException | ||
| */ | ||
| public static function detachedEntityFoundThroughRelationship(array $assoc, $entry) | ||
| /** @psalm-param array<string, string> $assoc */ |
There was a problem hiding this comment.
Probably something we should fix on a lower branch: The method has a pretty strong opinion on which keys should be defined on that array. It might be worth either documenting the shape or splitting $assoc into three (?) parameters.
greg0ire
force-pushed
the
php8-migration
branch
from
41370fe to
13d3ed0
Compare
|
Rebase needed. |
|
🤦 sorry |
greg0ire
force-pushed
the
php8-migration
branch
from
13d3ed0 to
f84c0a1
Compare
derrabus
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.