Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse association mapping array shape #10403

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Conversation

greg0ire
Copy link
Member

No description provided.

@mpdude
Copy link
Contributor

mpdude commented Jan 15, 2023

May I ask why such changes are made on 2.15, not on 2.14?

I understand that 2.14 is the current bugfix branch, and this is not a bugfix.

The idea of separating bugfix from feature branches (as I get it) is to avoid as many changes as possible on the bugfix one, to avoid the risk of unintentional breakage.

A change like this one here, however, does not change the running code, does it? It only improves static analysis capabilities and thus might be helpful for people fixing things on 2.14?

So why not merge such changes there?

@greg0ire
Copy link
Member Author

It might break static analysis on a downstream project. I use 2.14.x for phpdoc that is wrong. The current annotations are vague but not wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants