Field mapping improvements #10408
Merged
Field mapping improvements #10408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
field-mapping-improvements
branch
from
2ad64a9 to
d212713
Compare
|
@michnovka please review |
michnovka
suggested changes
Jan 15, 2023
| @@ -1584,7 +1586,7 @@ private function isTypedProperty(string $name): bool | |||
| * | |||
| * @param array{fieldName: string, type?: mixed} $mapping The field mapping to validate & complete. | |||
There was a problem hiding this comment.
if we update return type, we should update the type?: string here in param too
| @@ -1628,7 +1630,7 @@ private function validateAndCompleteTypedAssociationMapping(array $mapping): arr | |||
| * enumType?: class-string, | |||
| * } $mapping The field mapping to validate & complete. | |||
| * | |||
| * @return mixed[] The updated mapping. | |||
| * @return FieldMapping The updated mapping. | |||
There was a problem hiding this comment.
FieldMapping type has a compulsory array-key columnName. I am not sure that this is satisfied here, as the function does not set it and @param $mapping does not specify it.
There was a problem hiding this comment.
It's satisfied right below the comment "Complete fieldName and columnName mapping"
There was a problem hiding this comment.
sorry, my bad I was working on some badly lined version in my local repo.
There was a problem hiding this comment.
No worries, and thanks for reviewing 👍
greg0ire
force-pushed
the
field-mapping-improvements
branch
from
d212713 to
c0a7317
Compare
SenseException
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be hard to finish #10405, but this should get us closer to it.
Also, I learnt that DTOs shouldn't be used in mapping drivers, because drivers produce incomplete field mappings (they might not have a type), and also produce mapping overrides that might have even fewer fields. DTOs should be used in the class metadata and its consumers.