Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ParserResult to PHP 8 syntax #10448

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Migrate ParserResult to PHP 8 syntax #10448

merged 1 commit into from
Jan 24, 2023

Conversation

greg0ire
Copy link
Member

No description provided.

SenseException
SenseException approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My inner Monk would prefer to remove the underscore prefixes in the property names before merging.

@greg0ire
Copy link
Member Author

@SenseException I considered it, but these are private properties, so nothing prevents from doing this on 2.15.x. Let's try to find them throughout the project?

@greg0ire greg0ire merged commit fbcf91d into doctrine:3.0.x Jan 24, 2023
@greg0ire greg0ire added this to the 3.0.0 milestone Jan 24, 2023
@greg0ire greg0ire deleted the php8-migration branch January 24, 2023 07:58
@greg0ire greg0ire mentioned this pull request Jan 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
BC Break
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@greg0ire @SenseException