Fix some tests that were missed in #10431 #10464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In doctrine#10431, some invalid inheritance declarations in our test base were fixed. However, the change missed to update XML, PHP and static PHP mapping configurations as well. Apparently, this did not raise any flags because the misconfiguration only caused a deprecation notice in 2.15.x. Running the tests against 3.0 (where the misconfiguration will be an error) unveiled the mistake.
|
Should deprecation messages triggered by the test base be an error, or how could I have spotted this on 2.15 already? |
derrabus
approved these changes
Jan 26, 2023
This is currently not the case. Maybe it should. |
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Jan 27, 2023
* 2.15.x: Psalm 5.6.0, PHPStan 1.9.14 (doctrine#10468) Fix some tests that were missed in doctrine#10431 (doctrine#10464) Remove commented-out code sections (doctrine#10465)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #10431, some invalid inheritance declarations in our test base were fixed. However, the change missed to update XML, PHP and static PHP mapping configurations as well.
Apparently, this did not raise any flags because the misconfiguration only caused a deprecation notice in 2.15.x. Running the tests against 3.0 (where the misconfiguration will be an error) unveiled the mistake.
Reviewers: Compare to https://github.com/doctrine/orm/pull/10431/files#diff-3acd7a05f18efb0e3cb41d042f0699ff8f97ce91c3964f9ee588cb876304449b, this PR here does the same change for the other mapping types.