Handle null comparisons in ManyToManyPersister
#10587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5587, #5827 and #7717
The reason for
orm/lib/Doctrine/ORM/Persisters/SqlValueVisitor.php
Lines 34 to 38 in a50a611
BasicEntityPersister
replaces null comparisons withIS [NOT] NULL
so it does not need the corresponding parameter.Problem is,
ManyToManyPersister
has then no longer access to the comparison.My fix is to remove the condition in
SqlValueVisitor
and make each persister wary of null comparisons. It feels super weird but tests pass.