Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw on invalid one to one #10667

Merged
merged 1 commit into from
May 3, 2023
Merged

Throw on invalid one to one #10667

merged 1 commit into from
May 3, 2023

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented May 2, 2023

One to one relationships are not allowed to define a join column. That should be done on the owning side of the relationship.

@greg0ire
Copy link
Member Author

greg0ire commented May 2, 2023

@mpdude please review

SenseException
SenseException reviewed May 2, 2023
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, that this isn't a deprecation anymore and an unacceptable configuration that leads to an exception, shouldn't it get a test?

mpdude
mpdude previously approved these changes May 3, 2023
View reviewed changes
@greg0ire
Throw on invalid one to one
fac8d84 
One to one relationships are not allowed to define a join column. That
should be done on the owning side of the relationship.
@greg0ire greg0ire force-pushed the throw-on-invalid-oto branch from 722becd to fac8d84 Compare May 3, 2023 19:30
@greg0ire greg0ire requested a review from SenseException May 3, 2023 19:38
@greg0ire
Copy link
Member Author

greg0ire commented May 3, 2023

@SenseException I added a test :)

@greg0ire greg0ire added this to the 3.0.0 milestone May 3, 2023
@greg0ire greg0ire merged commit d075f5d into doctrine:3.0.x May 3, 2023
@greg0ire greg0ire deleted the throw-on-invalid-oto branch May 3, 2023 21:25
@greg0ire greg0ire mentioned this pull request Feb 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpdude mpdude mpdude approved these changes

@SenseException SenseException SenseException approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
BC Break
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@greg0ire @SenseException @mpdude