Changing return type of getSingleScalarResult() to array|bool|float|int|string|null
#10695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t|int|string|null` Reason: I'm using `intval()` to sanitize the result of `getSingleScalarResult()`. But now, PHPStan 1.10.15 complains that `intval()` only accepts `bool|float|int|resource|string|null` as input: phpstan/phpstan#9295 So I threw all of these (except `resource`) in here :-) I didn't doublecheck anything - waiting for some feedback first.
|
I didn't find this PR before, so I've created #10721. Sorry for that.
Based on n my tests, I can confirm this method can not return |
|
Never mind - so I'm closing here :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: I'm using
intval()to sanitize the result ofgetSingleScalarResult(). But now, PHPStan 1.10.15 complains thatintval()only acceptsbool|float|int|resource|string|nullas input: phpstan/phpstan#9295So I threw all of these (except
resource) in here :-)I didn't doublecheck anything - waiting for some feedback first.