Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve functional test cases expecting NonUniqueResultException from AbstractQuery::getSingleScalarResult() #10722

Merged
merged 1 commit into from
May 23, 2023

Conversation

phansys
Copy link
Contributor

@phansys phansys commented May 23, 2023

  • QueryTest::testGetSingleScalarResultThrowsExceptionOnNonUniqueResult() was updated to ensure NonUniqueResultException is thrown only on results with multiple rows;
  • QueryTest::testGetSingleScalarResultThrowsExceptionOnSingleRowWithMultipleColumns() was added to ensure NonUniqueResultException is thrown only on results with multiple columns;

…tion` from `AbstractQuery::getSingleScalarResult()`
@phansys phansys marked this pull request as ready for review May 23, 2023 09:06
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that's a test method name. :-)

@greg0ire greg0ire merged commit 10eae1a into doctrine:2.15.x May 23, 2023
@phansys phansys deleted the query_single_result_exception branch May 23, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants