Make the join table name and join column name mandatory #10729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not seem to ever be empty
greg0ire
changed the title
|
ping @derrabus @SenseException 🙏 |
Comment on lines
50
to
51
| if (isset($mappingArray['joinTable'])) { | ||
| if (isset($mappingArray['joinTable']['joinColumns'])) { |
There was a problem hiding this comment.
isset($mappingArray['joinTable']['joinColumns'])) should be enough here.
greg0ire
force-pushed
the
mandatory-table-name
branch
from
0b63115 to
ee62934
Compare
SenseException
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while working on migrating towards the object API of
Join{Column,Table}Mapping.