Add a test case to show #9376 and #9377 have been resolved #10733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
mpdude
changed the title
mpdude
changed the title
greg0ire
reviewed
May 31, 2023
This is part of the series of issues fixed by doctrine#10547. In particular, the changes from doctrine#10566 were relevant. See doctrine#9376 for the bug description; doctrine#9377 is obsoleted by doctrine#10547.
greg0ire
reviewed
May 31, 2023
greg0ire
reviewed
May 31, 2023
| * @ORM\ManyToOne(targetEntity=GH9376Gift::class) | ||
| * @ORM\JoinColumn(nullable=false) | ||
| * | ||
| * @var GH9376Gift |
There was a problem hiding this comment.
The variant points to the gift and nothing else
| /** | ||
| * @Entity | ||
| */ | ||
| class GH9376Product |
| /** | ||
| * @Entity | ||
| */ | ||
| class GH9376Gift |
There was a problem hiding this comment.
The gif points to a product and nothing else.
So the graph is like Variant -> Gift -> Product
🤔 where is the circular reference?
There was a problem hiding this comment.
What a careful reader you are. Test originally comes from here: https://github.com/doctrine/orm/pull/9377/files#diff-aa92ab1b41151bbdb1e6af1f38699ad708680e99bdf4420b56b9eddd64376061
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the series of issues fixed by #10547. In particular, the changes from #10566 were relevant.
See #9376 for the bug description.
The suggested fix in #9377 is obsoleted by #10547.