Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document pdo_sqlite requirement for tests #10734

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

greg0ire
Copy link
Member

The error message you get if you don't enable pdo_sqlite mentions a driver, but does not tell the users that it's provided by this PHP extension.

@greg0ire greg0ire mentioned this pull request May 31, 2023
CONTRIBUTING.md Outdated
Comment on lines 44 to 45
for PDO: `pdo_sqlite`. How to do so depends on your system, but checking can it
is enabled can universally be done with `php -m`: that command should list the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"checking can it is enabled can"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops! Fixed!

The error message you get if you don't enable pdo_sqlite mentions a
driver, but does not tell the users that it's provided by this PHP
extension.
@greg0ire greg0ire requested a review from SenseException June 1, 2023 05:46
@derrabus derrabus added this to the 2.15.2 milestone Jun 1, 2023
@derrabus derrabus merged commit 14d1eb5 into doctrine:2.15.x Jun 1, 2023
@greg0ire greg0ire deleted the enable-sqlite branch June 1, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants