distinct() updates QueryBuilder state correctly

[macroparts]

Previously calling distinct() when the QueryBuilder was in clean state would cause subsequent getDQL() calls to ignore the distinct queryPart

Fixes #10784

[greg0ire]

2.14.x is no longer maintained. I retargeted on 2.15.x, and now there is a conflict.

[macroparts]

Conflicts are resolved now.

[greg0ire]

The build failure seems unrelated to your changes 🤔

[greg0ire]

slevomat/coding-standard published a minor release 4 hours ago, that's why.

[macroparts]

Should I fix those in my PR or are these fixed separately?

[greg0ire]

I don't think you can fix them: slevomat/coding-standard#1585
The best course of action might be to add a version constraint preventing 8.13.0 in a separate PR.

[macroparts]

Their maintainers might provide a fix for the broken comment parsing in their latest release soon. I'll leave it for now and check back on Monday.

[greg0ire]

They are usually quite swift, so yeah, maybe. Also, it might be possible to work around some of the issues (use @param instead of @psalm-param, avoid @\, etc.

[greg0ire]

Addressed in #10790

[greg0ire]

Thanks @macroparts !

[macroparts]

Thank you @greg0ire !