Fix enum change set recomputation on single entity #10806
Conversation
|
@HypeMC @michnovka please review |
|
Give me until weekend to have a look. Also @rmikalkenas , could you please
explain in few words what this does and why is it needed?
…On Wed, Jun 28, 2023, 14:12 Grégoire Paris ***@***.***> wrote:
@HypeMC <https://github.com/HypeMC> @michnovka
<https://github.com/michnovka> please review
—
Reply to this email directly, view it on GitHub
<#10806 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD6JI7Y3AEQWU4WIAPVT2H3XNQNT5ANCNFSM6AAAAAAZW4UO5A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Updated my initial message |
|
@greg0ire is there anything I could help so that this PR gets merged and released as patch version? |
|
I'll try to review it soon, unless another maintainer beats me to it. |
|
The commit message should allow us to understand this change without access to the internet. Please improve your commit message according to the contributing guide. Both links contains list to other issues… do I need to read 4 pages to understand this? The rest of the PR description is good, as it gives some insight on what this might be about. |
rmikalkenas
force-pushed
the
fix-enum-recomputation
branch
from
176dbc5 to
2d08ba8
Compare
…enum attributes. Due to the fact that originalEntityData contains enum objects and ReflectionEnumProperty::getValue() returns value of enum, comparison of values are always falsy, resulting to update columns value even though it has not changes.
rmikalkenas
force-pushed
the
fix-enum-recomputation
branch
from
2d08ba8 to
c1018fe
Compare
|
@greg0ire thanks for your time reviewing the PR 🙏 |
|
Thanks @rmikalkenas ! |
|
When do you plan to release version 2.15.4? |
|
Soon. |
The root cause is well explained in #10074 and #10277
These PRs mitigate the issue in
computeChangeSetmethod, but in some casesrecomputeSingleEntityChangeSetmight also be called.One of the cases where
recomputeSingleEntityChangeSetmight be called are in event listeners when you want to modify some other existing entity. Due to the fact thatoriginalEntityDatacontains enum objects andReflectionEnumProperty::getValue()returns value of enum - comparison of values are always falsy, resulting to update column value even though its exactly the same. In case nothing changed in entity it can even result to additional queries to DB if entity contains enum attribute