Verify UnitOfWork::HINT_DEFEREAGERLOAD exists and is true

[oscmarb]

In some EAGER relationships a proxy instance is always retrieved instead of an instance of the class. This is because there is the UnitOfWork::HINT_DEFEREAGERLOAD hint, which cannot be deactivated even when the DQL indicates that the load should be EAGER or when we execute:

$query->setHint(UnitOfWork::HINT_DEFEREAGERLOAD, false);

With the change introduced by executing the line above, the value of HINT_DEFEREAGERLOAD will be taken into account, and lazy loading will only occur when HINT_DEFEREAGERLOAD is true.

[dvil88]

I'm having the same problem and this definitely solved it.

[greg0ire]

Can you please add tests?

[greg0ire]

Please read the contribution guide, it shows how to deal with failing checks locally.

[oscmarb]

Yep, sorry, I forgot to run cs. It is fixed.

[greg0ire]

Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble.

How to do that?

1. git rebase -i origin/2.15.x, assuming origin is a git remote that points to this repository, and not your fork. If you're not sure what your remotes are, run git remote -vvv, there should be your fork and the holy/reference/base/origin/whatever-you-call-it repository.
2. A window will show up with many lines, replace pick with fixup on every line but the first one
3. Close your editor, git should do its magic, and you should end up with one commit
4. Use git push --force to overwrite what you already push. Don't forget the --force option otherwise git will try to merge both things together.

[oscmarb]

All done.

The base branch was changed.

[greg0ire]

Thanks @oscmarb !