Allow to disable "DISTINCT" in LimitSubqueryWalker #10970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @goetas ! You should target 2.17, this is a new feature, right? |
greg0ire
reviewed
Oct 7, 2023
greg0ire
reviewed
Oct 7, 2023
|
Thanks for the review, all suggestions make sense, will address them tomorrow |
goetas
force-pushed
the
distinct-limit
branch
2 times, most recently
from
83c024d to
54c38f3
Compare
beberlei
previously approved these changes
Oct 9, 2023
greg0ire
reviewed
Oct 9, 2023
|
suggestions applied |
derrabus
approved these changes
Oct 9, 2023
|
Thanks @goetas ! |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10553
Im not sure what is the correct branch to target.. 2.16 or 2.17...